shosetsuorg / shosetsu

An android application for reading light novels. Moved to https://gitlab.com/shosetsuorg/shosetsu
https://shosetsu.app
GNU General Public License v3.0
584 stars 34 forks source link

[Bug] [2.0.0-1656] Extension settings don't load the first time #157

Closed khonkhortisan closed 3 years ago

khonkhortisan commented 3 years ago

Describe the bug

  1. The next extension to have its settings opened won't show its settings: a. after shosetsu is fully closed b. sometimes after opening it from the list of running apps), the next extension to have its settings opened won't show its settings. and it'll c. sometimes say This extension has no settings! d. sometimes not say that

To Reproduce Steps to reproduce the behavior:

  1. Open shosetsu
  2. Switch to Browse tab
  3. Click any settings gear ⚙️
  4. See the extension image, name, id, filename, language, trashbutton
  5. Don't see the listings dropdown nor any other settings
  6. Click back ←
  7. Click any settings gear ⚙️, not necessarily the same one as before
  8. Step 4 "See the extension image, name, id, filename, language, trashbutton"
  9. Opposite of step 5, see the listings dropdown and any other settings

Expected behavior Click any settings gear ⚙️, see the listings dropdown and any other settings

Screenshots

Device information:

AND

Additional context Add any other context about the problem here.

Doomsdayrs commented 3 years ago

This is my priority right now, I am working on replacing the old hacked together extension settings with jetpack compose and proper techniques

Doomsdayrs commented 3 years ago

Fixed with b770d4d