search

shosetsuorg / shosetsu

An android application for reading light novels. Moved to https://gitlab.com/shosetsuorg/shosetsu
https://shosetsu.app
GNU General Public License v3.0
584 stars 34 forks source link

[Bug] [2.0.0-1678] Duplicate FILTER pop-ups #167

Closed khonkhortisan closed 2 years ago

khonkhortisan commented 2 years ago

Describe the bug These pop-ups can be duplicated by spamming the button that opens them

My library→FILTER         (record:  6 copies)
Browse→FILTER             (record: 21 copies)
Browse→[extension]→FILTER (record:  4 copies)

To Reproduce Steps to reproduce the behavior:

  1. Hold your finger above the screen, where the FILTER button will be
  2. Open the app or switch to the My library tab or switch to the Browse tab or open an extension
  3. Tap as fast as you can to open duplicate FILTER pop-ups
  4. Scroll inside or tap outside the FILTER pop-up to close it and count how many duplicates there were

Expected behavior A clear and concise description of what you expected to happen.

Screenshots

Device information:

Additional context This should not be fixed by replacing the previous pop-ups with the last opened one, because that would make it take longer to be responsive again. It should be fixed by only opening the first pop-up and ignoring future attempts until the first pop-up is closed.

relevant code: LibraryController.kt:324 BrowseController.kt:204 CatalogController.kt:319 manipulateFAB()