shosetsuorg / shosetsu

An android application for reading light novels. Moved to https://gitlab.com/shosetsuorg/shosetsu
https://shosetsu.app
GNU General Public License v3.0
576 stars 34 forks source link

F-Droid Support #50

Closed roshavagarga closed 4 years ago

roshavagarga commented 4 years ago

Hello,

Have you considered applying to have Shosetsu added to F-Droid?

TheCloudCrafter commented 4 years ago

you can add it manually but idk github well enough to get a distro link. Just too lazy to look into it. I pay attention to discord pings.

Doomsdayrs commented 4 years ago

ITs soooooo complicated

roshavagarga commented 4 years ago

You can start the process and let it stew on gitlab. Some apps get submitted by the owners with an admission that they do not have the time to fix everything but are open to help and volunteers help them out :)

roshavagarga commented 4 years ago

You can also just give approval and I can at least fill it out so that your app gets checked?

roshavagarga commented 4 years ago

@Doomsdayrs Are you at least open to having Shosetsu added to F-Droid?

Doomsdayrs commented 4 years ago

Yes i am, i just don't have the patience to try and figure out how to do it xD

roshavagarga commented 4 years ago

@Doomsdayrs

  1. It has to conform to these.
  2. If 1 is true, then open a merge request here.

Then it just has to be checked for building, if everything's alright, it gets added by the F-Droid volunteers when everything has been a-okay'd.

Doomsdayrs commented 4 years ago

TBH why can't there be an automated way to do this, seems so complicated for a simple appstore

roshavagarga commented 4 years ago

Because F-Droid is centered around submitted apps being FLOSS. Nothing used to maintain, create or enable the app's functionality can be non-free. While some of this can and is automated, other parts are viewed by humans to make sure no shenanigans happen.

Think of this as the app store for people concerned about their privacy - they want everything to be open for others to check, and if it does use analytics or advertisements, they have to also be FLOSS, so nothing can happen behind the scenes.

TheCloudCrafter commented 4 years ago

A workaround could be to setup a repo and simply manually add it as a source in fdroid?

https://help.github.com/en/articles/about-remote-repositories

TheCloudCrafter commented 4 years ago

Takiyomi repo for example

https://j2ghz.github.io/repo

Doomsdayrs commented 4 years ago

So if we just have a file in this repo that is just like that repo, then we can add it to fdroid?

Doomsdayrs commented 4 years ago

ah, nvm i get it now

roshavagarga commented 4 years ago

I'd still recommend going through the motions and getting it added to the F-Droid repo. There is currently no app for reading light novels and/or web novels on F-Droid.

IzzySoft commented 4 years ago

@Doomsdayrs not that hard. Someone just opened a Request For Packaging. But may I suggest you add Fastlane file structure to your repo here – to provide screenshots and manage the app description yourself? Fastlane can also be used for deployment to Google Play btw.

For the screenshots in Fastlane I suggest using "non-framed" ones – considering the small screen estate on phones. That way the users get more details :wink:

For the description:

For a pre-check, I've just added your app to my repo (should turn up here with tomorrow's sync – today's sync just was done an hour ago) – it seems to meet the criteria for the official repo.

Oh, almost forgot to disclose: I'm one of the F-Droid maintainers.

Doomsdayrs commented 4 years ago

Seems like an easy thing to do, I'll be able to get it done tonight

IzzySoft commented 4 years ago

Great, thanks! Just ping me again when it's ready. That bot of ours will also be run until then (hopefully; runs once per day and I never remember at what time :rofl:)

Doomsdayrs commented 4 years ago

@IzzySoft 9829de0 on master adds fastlane support, tho i don't have a featureGraphic, tvBanner, or promoGraphic

IzzySoft commented 4 years ago

@Doomsdayrs that's fully fine – all elements are optional. Now we just need a tag covering fastlane, and we can go on. The bot has scanned your repo meanwhile; it spit two warnings you might wish to look at (not affecting builds done by F-Droid, but your own).

Doomsdayrs commented 4 years ago

Hmm, Ill added the keys

Doomsdayrs commented 4 years ago

@IzzySoft Seems android studio doesn't support building with the sum's, Oh well

IzzySoft commented 4 years ago

I vaguely remember there were some issues introduced by a Studio update – but not being an Android dev myself, I don't remember the solution. Well, feel free to ignore that warning then: as I wrote, it's no show-stopper for F-Droid as we replace this part anyway. Just have a tag covering fastlane, and I can mark the RFP for our packagers to process.

Doomsdayrs commented 4 years ago

@IzzySoft v1.1.1 (code 24) released just now, isn't different to v1.1.0, just a vcode upgrade and schema increment

IzzySoft commented 4 years ago

Thanks! I've just prepared the metadata in the RFP and marked it ready for packaging.

Concerning your previous edit: yes, a new tag/release should always have versionCode increased – that's what Android tells versions apart and decides which one is the newer. As this is the first version we're packaging at F-Droid, it doesn't much matter for us this time – but for the future, please remember it :wink:

Now we're waiting for a packager to pick up. As the F-Droid team is permanently understaffed, it might take a little. Should nothing happen in, say, about 2 weeks, feel free to ping me again so I can check (and forward the ping to our packagers).

Doomsdayrs commented 4 years ago

@IzzySoft A ping for you!

IzzySoft commented 4 years ago

@Doomsdayrs forwarded, thanks!

Doomsdayrs commented 4 years ago

Added to fdroid as of https://gitlab.com/fdroid/fdroiddata/merge_requests/6212

IzzySoft commented 4 years ago

Congrats! I'll then remove it from my repo as soon as it pops up at f-droid.org (you've stopped attaching APKs after v1.1.0 anyway, so I'm no longer able to update; you might wish to fill that gap for v1.1.3 to bridge the time until then).

Doomsdayrs commented 4 years ago

I stopped attaching apks because all the versions are the same code wise ;p

IzzySoft commented 4 years ago

Ah, I should have read the release notes :rofl: