search

shotgunsoftware / python-api

A Python-based library for accessing Flow Production Tracking API.
https://developer.shotgridsoftware.com/python-api
Other
306 stars 198 forks source link

Use ProxyHandler for uploads when using proxy elsewhere #182

Closed apetrynet closed 3 years ago

apetrynet commented 6 years ago

To avoid having to use the http_proxy environment variable when uploading files behind a proxy, this patch creates a ProxyHandler rather than a HTTPHandler when the self.config.raw_http_proxy is set.

apetrynet commented 6 years ago

Hmm. Not quite sure what's causing the failed tests here. Does it have to do with my change at all or is it because master (which I forked from) is broken at the moment?

victoriagrey commented 6 years ago

Hi @apetrynet ,

Thanks for the Pull Request! We'll have a run through it and get back to you.

As for the failed tests, that's probably just because of our CI setup (it's not very friendly to submitters external to the shotgun org). So don't worry about that for now :).

Cheers, Neil

apetrynet commented 6 years ago

Cool!

apetrynet commented 3 years ago

Seems like something similar to this is implemented, so closing the PR