SG-13267: Config fixes for Mockgun

shotgunsoftware / python-api

A Python-based library for accessing Flow Production Tracking API.

https://developer.shotgridsoftware.com/python-api

Other

306 stars 198 forks source link

SG-13267: Config fixes for Mockgun #215

Closed jfboismenu closed 4 years ago

jfboismenu commented 4 years ago

Mockgun never initialized the values inside the _Config instance, which is causing some issues in Python 3 because of None values being passed into urllib methods.

I've added the required tests.

willis102 commented 4 years ago

I'm going to merge this onto SG-13264-update_sgsix and I'll be updating the python3 branch on tk-core with the latest from there.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 1282

7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 68.559%

Totals
Change from base Build 1267:	-0.2%
Covered Lines:	5397
Relevant Lines:	7872

💛 - Coveralls

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 1282

7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 68.77%

Totals
Change from base Build 1267:	0.05%
Covered Lines:	6767
Relevant Lines:	9840

💛 - Coveralls

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 1282

7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 68.77%

Totals
Change from base Build 1267:	0.05%
Covered Lines:	6767
Relevant Lines:	9840