shotgunsoftware / python-api

A Python-based library for accessing Flow Production Tracking API.
https://developer.shotgridsoftware.com/python-api
Other
308 stars 198 forks source link

Fix flaky upload tests. #313

Closed NorberMV closed 1 year ago

NorberMV commented 1 year ago

This PR fixes flaky tests that contain the following errors:

- AssertionError: 'image/png' != 'image/jpeg'
- AssertionError: '304' != '200'

Allows upload requests with status '304' in the thumbnail upload tests, because sometimes when the response hasn't been modified, this status informs the client that the response has not changed, so the client can continue using the same cached version.

Also supports transient placeholder PNG file content types in the response payload, since sometimes it takes longer for the previously uploaded image requested to be available from media storage, and we have previously tested that the image was successfully uploaded.