search

shotgunsoftware / python-api

A Python-based library for accessing Flow Production Tracking API.
https://developer.shotgridsoftware.com/python-api
Other
308 stars 198 forks source link

SG-34551 validation for python3, so display_name now is only decoded … #337

Closed eduardoChaucaGallegos closed 5 months ago

eduardoChaucaGallegos commented 7 months ago

Now prefix/suffix if display_name property exists is not added

eduardoChaucaGallegos commented 7 months ago

@julien-lang By the moment I couldn't see other fields with that potential problem in the scope of "_upload_to_sg" function because it is the only one field that previously was encoded to utf-8(encode("utf-8")) to assurance the behavior of non-ascii unicode and utf-8 string paths during upload. Also I believe that is not necessary a new test for that new condition because that function and complete upload flow already has a unit tests. There exists a possibility to use another python2 "runner" in settings of CI/CD, but If I'm not wrong, we only will support python3 in the next weeks