search

shotgunsoftware / tk-framework-adobe

Foundation Tech for all Adobe Integrations
https://developer.shotgridsoftware.com/tk-framework-adobe/
Other
10 stars 8 forks source link

SG-7336 Hard to see SG project name in Photoshop/After Effects: missing contrast between text and background #34

Closed julien-lang closed 1 year ago

julien-lang commented 1 year ago

The project link (after being clicked once) is displayed in a color that is not contrasted enough with the background

image

julien-lang commented 1 year ago

Please check my last commit. I am not so sure if we want to differentiate the sg_value_link from other links. I could not find other links to compare it with. Basically, regular links would be "blue" and sg_value_link would be white.

I think blue is better since the hover is white.

julien-lang commented 1 year ago

!, not sure if maybe this change will require to bump the version and repackage before merge.

This is a good point @NorberMV! I am going to investigate about that.

julien-lang commented 1 year ago

not sure if maybe this change will require to bump the version and repackage before merge.

This is a good point @NorberMV! I am going to investigate about that.

Done, check the last commit.

julien-lang commented 1 year ago

Seems like you´ll need to run the linter, the code validation is failing on Azure.

Fixed!

maybe should we update something in the README.md about the process of recompile the plugin

I agree that the README steps are not very clear but it is out of topic here. I'd rather do it in a different ticket.