SHOT-4354: API backward compatibility fix - Githubissues

shotgunsoftware / tk-multi-breakdown2

A Flow Production Tracking Pipeline Toolkit app that helps you see what is out of date in your scene across multiple projects.

https://developer.shotgridsoftware.com/tk-multi-breakdown2/

Other

4 stars 10 forks source link

SHOT-4354: API backward compatibility fix #75

Closed staceyoue closed 6 months ago

staceyoue commented 6 months ago

Fix breaking api change to method BreakdownManager::scan_scene. This method was refactored to allow the file model to execute the scan scene in incremental steps to improve performance, but the return value was changed from List[FileItem] to List[dict]. This PR reverts this api breaking change.

This fixes Apps that use the Breakdown2 api:

tk-multi-scenebuilder
tk-multi-workfiles2 (feature that is on turned on via config)

Changes:

scan_scene should return a list of FileItem objects (as it did before)
Add new method get_scene_objects to get the scene objects as a list of dicts
Fix missing filters passed to SG query when not using BG task manager
Update unit tests

staceyoue commented 6 months ago

Closing, included in dependent PR #76