search

shotgunsoftware / tk-multi-importcut

Import Cut app
Other
0 stars 0 forks source link

For #35628, #35000, and 35626, improved success screen, added support for base layer media, and user can now create linked entity on the fly #20

Closed raphaelmatto closed 8 years ago

raphaelmatto commented 8 years ago

This is a combined pull request for three tickets, the title says it all!

sgsteph commented 8 years ago

Code review done. I feel like the EDL / MOV handling should be revisited with dedicated signals / slots instead of storing file paths in the dialog instance, and then using load_edl to handle both.

I noticed some pngs were changed. Some of them had some corresponding svg files in the resources folder. If the new png were generated from svg files, it would be great to replace the old svg files with the new ones (e.g. left_arrow.svg). If svg files are not available for the new png, may be the old svg files should be discarded so another developer wouldn't wrongly start from them if some tweaking is needed ?