search

shotgunsoftware / tk-multi-importcut

Import Cut app
Other
0 stars 0 forks source link

35606 improved merged entity screens #24

Closed sgsteph closed 8 years ago

sgsteph commented 8 years ago

Here is what I came up with. Have a look, and let me know if I can merge it on your branch. I have the feeling that we have some conflicts between the two branches, so might be better if I do the merge ?

raphaelmatto commented 8 years ago

Before I look at the code, I thought I'd give it a test run. Here are some problems we'll want to sort out before merging:

1) The styling on the cards has changed, there's a lot of space between them now.

2) The styling on the "tab buttons" has been lost.

3) After dropping an edl and moving to the next screen, nothing shows up. It seems the cards are loaded, but I have to click on the "Scene" button. After that interaction is fast! Interestingly, behavior is correct in RV. Perhaps you did your dev in RV?

4) The user-preference tab-persistence functionality has been lost—so for example when the app is relaunched, the "Sequence" tab should be preselected, if that's the tab the user chose from during the previous Import Cut session.

raphaelmatto commented 8 years ago

Okay, I had a look through the code. Very interesting how you're adding pages on the fly to the stacked widget. I think the strategy is good—you're moving work out of the entities_view and back to the dialog. So long as we can get the styling/functionality issues I mentioned sorted out (as well as the scroll bar issue you brought up), I'm very happy to switch to this code.

sgsteph commented 8 years ago

Closing this pull request it is outdated because of changes on the target branch