search

shotgunsoftware / tk-multi-importcut

Import Cut app
Other
0 stars 0 forks source link

#36096 Toolkit Code Review #47

Closed manneohrstrom closed 8 years ago

manneohrstrom commented 8 years ago

Code Review from a Toolkit best practices standpoint. This review takes a high level perspective - a lot of the low level review is happening in #44, so no need to redo that work.

sgsteph commented 8 years ago

Heads up that I prepared a branch with all changes so far here: https://github.com/shotgunsoftware/tk-multi-importcut/commit/5fdaa329fde991ada51a35234f0e9a9600605791 Plan is to address comments on clean up branch, merge onto master. Merge any changes made on clean up branch onto the mentioned one, and submit a pull request. So you might want to change your pull request to point to the mentioned branch if you want to check most up to date changes ?

manneohrstrom commented 8 years ago

@sgsteph asked me to hold off until all the merge juggling had completed. Closing this PR -- this CR will instead happen in #50