Closed sgsteph closed 8 years ago
Looks good overall... good cleanup and fixes.
TBH, the smart field workarounds are extremely confusing. But this is due to SG not the code. We should have this documented somewhere (outside of here) so we can reference what is happening. We used to have docs about this with the API docs, but they're out of date. I didn't know you could actually update smart_*
fields as you used to not be able to and would update the raw fields from the API in order to get the smart_*
fields to return the expected values. I thought this was a better way to go in order to avoid running into these issues where the smart fields work differently than you want or expect them to when updating them.
Couple of very minor notes. Then ready to go. No need to re-review.
This pull request contains code written to address multiple tickets:
Additional bugs like a (rare) race condition were fixed as well.