36585 no restart on settings changes

shotgunsoftware / tk-multi-importcut

Import Cut app

Other

0 stars 0 forks source link

36585 no restart on settings changes #51

Closed sgsteph closed 8 years ago

sgsteph commented 8 years ago

Allow users to change settings without having to restart the app, but let them know bad things might happen.
Changing the frame rate implies reloading the EDL and reloading the Cut diff summary (if step is reached).
Changing other timecode / frame mapping values implies reloading (if step is reached).
Removed a class member and method which were useless since timecode / frame mapping values are retrieved from user settings.

manneohrstrom commented 8 years ago

CR done - some various comments, mostly around doc strings, naming, structure etc. I don't have a deep understanding of this code so trying to point out stuff to the best of my ability. I think my biggest question mark is around why each individual cut item seems to keep it's own copy of the preferences.

Please merge whenever.