search

shotgunsoftware / tk-multi-shotgunpanel

Access Flow Production Tracking data inside the artist app.
Other
6 stars 20 forks source link

Close the current panel on app destroy #18

Closed geffrak closed 7 years ago

geffrak commented 7 years ago

This avoid having a broken state when changing project in flame having the shotgun panel open.

This is linked to SMOK-42358.

Since it's a panel that is not only for flame, I don't know if this could break the workflow on others integrations. I don't think it will because the app seems to be destroyed only when the engine is getting destroyed.

mtiudaeu commented 7 years ago

Looks good!

manneohrstrom commented 7 years ago

This makes sense in context of the panel alone - however, we should think about this from a bigger perspective - it is the engine's responsibility to close windows, not something which should be implemented in each app.

The timing of this pull request is perfect, check out https://github.com/shotgunsoftware/tk-maya/pull/24 - where we are basically doing the same thing in maya.

We are now actively discussing in the toolkit group to introduce a more generic approach to closing windows in engines.

For the time being, I suggest adding engine level methods in the tk-flame engine that closes all open tk dialog windows when the engine is destroyed. See the maya PR for details!