search

shotgunsoftware / tk-multi-shotgunpanel

Access Flow Production Tracking data inside the artist app.
Other
6 stars 20 forks source link

Sg 22646 shotgrid #59

Closed zamu5 closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #59 (a7ad5a1) into master (2bd7b25) will not change coverage. The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   77.09%   77.09%           
=======================================
  Files          34       34           
  Lines        2392     2392           
=======================================
  Hits         1844     1844           
  Misses        548      548
Impacted Files Coverage Δ
app.py 49.29% <0.00%> (ø)
python/app/model_publish_history.py 77.14% <0.00%> (ø)
python/app/ui/resources_rc.py 88.88% <ø> (ø)
python/app/work_area_button.py 53.84% <ø> (ø)
python/app/action_manager.py 77.06% <100.00%> (ø)
python/app/shotgun_location.py 74.35% <100.00%> (ø)
python/app/ui/dialog.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2bd7b25...a7ad5a1. Read the comment docs.

jfboismenu commented 3 years ago

This is a tricky one to fix that would need more investment than we are ready to make at the moment. The tab is inserted via code that is injected into the workspace when the tab is mapped the very first time in Maya is launched. Renaming this risks breaking compatibility and we could end up losing where the user docker the dialog. If you change to a new Maya Workspace however you should be good and the panel should be named ShotGrid.

mathurf commented 3 years ago

We need to wait for tk-framework-qtwidgets to be done and merged in master before completing this PR. The reason is that the GUI tests will need to be updated.