search

shotnothing / pe

0 stars 0 forks source link

Filtering breaks when phone number is edited #5

Open shotnothing opened 1 week ago

shotnothing commented 1 week ago

Reproduction

  1. Start fresh install of app
  2. addTxn 1 amt/-24.3 desc/I owe John for dinner date/10102024
  3. filterTxn 1 shows two results
  4. edit 1 p/12345678
  5. filterTxn 1 shows one result

The newly added transaction is now missing when filtering.

I think this can be quite detrimental when tallying finances, as this gives the wrong result just by editing a contact number. The filter should still work the same after editing contacts.

Note the two Alex Yeoh transactions

image.png

Yet only one entry is seen on filter

image.png

Severity Justification
I believe this issue to be particularly severe as editing a contact is a very common thing to do and expected for the average user. However, the permeant yet silent breakage of filter giving wrong results will cause wrong amounts of money to be trackers/disbursed, and there is no obvious way to fix this except deleting the contact and re-adding every transaction again.

soc-pe-bot commented 1 week ago

Team's Response

Thank you for your feedback!

We appreciate you identifying this valid bug. After reviewing the issue, we observed that the filterTxn command must exist before the edit command for this bug to manifest. Users can work around the issue by ensuring that no filter is applied before editing a person's name, which can be done using the listTxn command.

Given this, we believe the impact of the bug is limited in scope and doesn't align with the criteria for "High Severity," which is reserved for issues that make the product almost unusable for most users. Instead, we will adjust the severity to "Medium," as it represents a flaw causing occasional inconvenience to some users, but they can still use the product effectively.

Screenshot 2024-11-17 at 9.07.08 PM.png

Thank you for your understanding, and we’re committed to improving the experience further!

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Medium] Originally [severity.High]

Reason for disagreement: Hi! Thank you for the response!

I am still going to stick to my opinion that this is a severe issue that warrants severity.High. The filterTxn workaround is mentioned nowhere in the UG or DG, and the average user should not be expected to know about this workaround. The workaround is also not obvious at all, and the breakage is silent, with not obvious way to identify something went wrong.

I am reviewing the 1.6 release as is (i.e. using the provided UG and DG) which does not state a workaround nor will the average user find out about this workaround, thus I do not personally consider this workaround any consolation.

The criteria for severity.High has two parts,

For the former, I believe that editing users and filtering transactions are very core, foundational features that every user will come across. This can be recreated with only 4 simple commands as well. As such, any user of this app will have a high likelihood of encountering this flaw, thus this an issue that I believe will affect most users.

As for the latter, the silent and insidious omission of transactions are particularly bad as monetary transactions are being left out, which can cause wrong amounts of money to be tracked/disbursed. As filtering transactions is also a very core feature of the app and its value proposition, I would classify it as a major problem. The breakage is silent with no way to discover the results are wrong, much less come up with a workaround (which, might I add, is not an obvious workaround as mentioned above).

As such, I strongly believe that this bug should be assigned severity.High and warrants the highest attention.