search

shotover / shotover-proxy

L7 data-layer proxy
https://docs.shotover.io
Apache License 2.0
84 stars 16 forks source link

cassandra protocol v5: replace slow crc implementation #1391

Open rukai opened 10 months ago

rukai commented 10 months ago

crc24 is very slow and crc32 implementation should be benchmarked against https://github.com/zowens/crc32c

rukai commented 8 months ago

conor wrote some benchmarks here https://github.com/conorbros/crc-benches And he found that we are already using the fastest crc implementations. I find this result a little surprising since crc32c uses an x86 instruction specifically for calculating crc32, so I'll do a bit of investigation before marking this as closed.

I've also remembered that a while back I wrote these benchmarks and then forgot about them: https://github.com/zowens/crc32c/pull/45