shotover / shotover-proxy

L7 data-layer proxy
https://docs.shotover.io
Apache License 2.0
84 stars 16 forks source link

Remove dummy message insertion #1576

Closed rukai closed 5 months ago

rukai commented 5 months ago

Some protocols, so far only kafka, have some requests which do not trigger a response. This is forbidden by our transform invariants, so to handle this we have logic in SinkConnection to insert dummy responses that correspond to those requests. This works but I've done some thinking and I am proposing that we throw this away and instead have the user just call the new respondable_id() method when they need to wait for a response on a protocol which may not send a response:

rukai commented 5 months ago

Whoops, this doesnt account for dummy messages needing a dummy response.