search

shotover / shotover-proxy

L7 data-layer proxy
https://docs.shotover.io
Apache License 2.0
83 stars 16 forks source link

Remove unneeded derives on transforms #1594

Closed rukai closed 4 months ago

rukai commented 4 months ago

The Clones are left over from when we used to Clone transforms to get a new one instead of using TransformBuilders.

I'm not sure where the Debug derives came from? They could be useful for debug printing but I've never wanted to debug print an entire transform, printing just a few relevant fields has always been more useful for me.

edit: I also added in some extra changelog entries that were missed in other recent work.

conorbros commented 4 months ago

Technically breaks our public API? I doubt it will matter in this instance, just something to keep in mind when changing the transform structs.

rukai commented 4 months ago

True, I'll add a note to the changelog.