Closed rukai closed 3 months ago
closes https://github.com/shotover/shotover-proxy/issues/1600
Possibly useful resources:
This PR introduces a new optional config to KafkaSinkCluster:
KafkaSinkCluster
authorize_scram_over_mtls: mtls_port_contact_points: ["172.16.1.2:9094"] tls: certificate_authority_path: "tests/test-configs/kafka/tls/certs/localhost_CA.crt" certificate_path: "tests/test-configs/kafka/tls/certs/localhost.crt" private_key_path: "tests/test-configs/kafka/tls/certs/localhost.key" verify_hostname: true
The documentation added in docs/src/transforms.md explains what this feature does and why we want it, so please refer to it.
docs/src/transforms.md
In terms of implementation decisions:
I looked into two crates to provide the SCRAM implementation
rsasl
sasl
In conclusion the sasl crate looked like a clear winner, so I went with it.
I've left the hardcoded 4 second delay in, it will be addressed along with caching delegation tokens in a follow up PR: https://github.com/shotover/shotover-proxy/issues/1618
closes https://github.com/shotover/shotover-proxy/issues/1600
Possibly useful resources:
This PR introduces a new optional config to
KafkaSinkCluster
:The documentation added in
docs/src/transforms.md
explains what this feature does and why we want it, so please refer to it.In terms of implementation decisions:
I looked into two crates to provide the SCRAM implementation
rsasl
cratesasl
crateIn conclusion the
sasl
crate looked like a clear winner, so I went with it.I've left the hardcoded 4 second delay in, it will be addressed along with caching delegation tokens in a follow up PR: https://github.com/shotover/shotover-proxy/issues/1618