scram_over_mtls - phase2 - caching task - Githubissues

shotover / shotover-proxy

L7 data-layer proxy

https://docs.shotover.io

Apache License 2.0

83 stars 16 forks source link

scram_over_mtls - phase2 - caching task #1626

Closed rukai closed 3 months ago

rukai commented 3 months ago

progress towards: https://github.com/shotover/shotover-proxy/issues/1618

This PR is the first step towards a more robust scram_over_mtls implementation:

It introduces a task that runs in the background and manages delegation tokens for all KafkaSinkCluster instances.
The task currently just implements caching of tokens across all connections.

In the future the task will also be used for:

detecting when tokens are ready to be used without a hardcoded sleep.
recreating tokens before they expire
prefetching all known tokens at startup

Since this task going down would leave the shotover instance in a very broken state:

unwrap/panic is never used, instead an error is returned for all error cases.
The task is wrapped in a loop that will restart the task from scratch if it encounters an error.

codspeed-hq[bot] commented 3 months ago

CodSpeed Performance Report

Merging #1626 will not alter performance

_{Comparing rukai:scram_over_mtls_phase2 (548d1e1) with main (1ea5cb5)}

Summary

✅ 37 untouched benchmarks