search

shotover / shotover-proxy

L7 data-layer proxy
https://docs.shotover.io
Apache License 2.0
83 stars 16 forks source link

KafkaSinkCluster: Improve unknown topic warnings #1629

Closed rukai closed 3 months ago

rukai commented 3 months ago

When we attempt to route a fetch request for which we have no record of its topic we issue a warning since it is impossible to route correctly. We were previously including the topic name (topic field) in the warning but the kafka protocol has deprecated the topic name in favor of the topic uuid (topic_id field) . This was resulting in warnings that look like: no known partition replica for topic "", routing message to a random node so that a NOT_LEADER_OR_FOLLOWER or similar error is returned to the client So this PR now uses the topic name if provided and fallsback to the topic id when needed.

codspeed-hq[bot] commented 3 months ago

CodSpeed Performance Report

Merging #1629 will not alter performance

Comparing rukai:kafka_improve_unroutable_warnings (75693ae) with main (0461a88)

Summary

✅ 37 untouched benchmarks