search

shotover / shotover-proxy

L7 data-layer proxy
https://docs.shotover.io
Apache License 2.0
84 stars 16 forks source link

KafkaSinkCluster: route LeaveGroup requests #1653

Closed rukai closed 4 months ago

rukai commented 4 months ago

When running cargo nextest run --no-default-features --features kafka kafka_int_tests::cluster_1_rack_single_shotover --nocapture logs from the java driver can be observed complaining that leavegroup requests were not routed to the coordinator of the group.

This is because shotover is simply not performing that routing! So this PR implements routing for LeaveGroup requests.

The fix can be confirmed by rerunning cargo nextest run --no-default-features --features kafka kafka_int_tests::cluster_1_rack_single_shotover --nocapture and observing that the error level logs are gone now.

codspeed-hq[bot] commented 4 months ago

CodSpeed Performance Report

Merging #1653 will not alter performance

Comparing rukai:route_leave_group_requests (bd90de2) with main (ec2a06d)

Summary

✅ 37 untouched benchmarks