shotover / shotover-proxy

L7 data-layer proxy
https://docs.shotover.io
Apache License 2.0
82 stars 16 forks source link

#1649 Add a microbenchmark for QueryCounter #1663

Closed justinweng-instaclustr closed 1 month ago

justinweng-instaclustr commented 1 month ago

This PR adds a benchmark function for QueryCounter which includes a chain of QueryCounter followed by Loopback. It sends several redis commands to trigger the increment of the QueryCounter metric.

Progress towards #1649

codspeed-hq[bot] commented 1 month ago

CodSpeed Performance Report

Merging #1663 will degrade performances by 11.57%

Comparing justinweng-instaclustr:1649-write-microbenchmark-for-querycounter (c75dc1b) with main (42ed20d)

Summary

❌ 1 regressions ✅ 36 untouched benchmarks

🆕 1 new benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main justinweng-instaclustr:1649-write-microbenchmark-for-querycounter Change
🆕 query_counter N/A 14.1 µs N/A
encode_system.local_result_v5_no_compression 92.8 µs 104.9 µs -11.57%
rukai commented 1 month ago

for the regression on the encode_system.local_result_v5_no_compression benchmark, I think that changing the benchmarks has just added some noise by making the benchmark executable compile slightly differently or leave the heap in a slightly different state.

So dont worry about it.