shotover / shotover-proxy

L7 data-layer proxy
https://docs.shotover.io
Apache License 2.0
82 stars 16 forks source link

#1656 Split up scram_over_mtls module into submodules #1679

Closed justinweng-instaclustr closed 2 weeks ago

justinweng-instaclustr commented 2 weeks ago

This PR splits up the original monolithic module scram_over_mtls into submodules recreate_token_queue and create_token in order to prepare for the improvement on token handling in https://github.com/shotover/shotover-proxy/issues/1667. It doesn't change the functionality of the module scram_over_mtls.

Closes #1656

codspeed-hq[bot] commented 2 weeks ago

CodSpeed Performance Report

Merging #1679 will create unknown performance changes

Comparing justinweng-instaclustr:1656-splitup-scram_over_mtls-module (c657ae9) with main (9c00122)

Summary

🆕 39 new benchmarks

Benchmarks breakdown

Benchmark main justinweng-instaclustr:1656-splitup-scram_over_mtls-module Change
🆕 cassandra_protect_protected N/A 74.4 µs N/A
🆕 cassandra_protect_unprotected N/A 43 µs N/A
🆕 cassandra_request_throttling_unparsed N/A 14.7 µs N/A
🆕 cassandra_rewrite_peers_passthrough N/A 81.6 µs N/A
🆕 loopback N/A 6.4 µs N/A
🆕 nullsink N/A 14 µs N/A
🆕 query_counter_fresh N/A 15.4 µs N/A
🆕 query_counter_pre_used N/A 11.9 µs N/A
🆕 redis_cluster_ports_rewrite N/A 18.9 µs N/A
🆕 redis_filter N/A 22.2 µs N/A
🆕 decode_system.local_query_v4_lz4_compression N/A 54.9 µs N/A
🆕 decode_system.local_query_v4_no_compression N/A 54.7 µs N/A
🆕 decode_system.local_query_v5_lz4_compression N/A 56.9 µs N/A
🆕 decode_system.local_query_v5_no_compression N/A 56.8 µs N/A
🆕 decode_system.local_result_v4_lz4_compression N/A 44.9 µs N/A
🆕 decode_system.local_result_v4_no_compression N/A 14.9 µs N/A
🆕 decode_system.local_result_v5_lz4_compression N/A 44.8 µs N/A
🆕 decode_system.local_result_v5_no_compression N/A 14.8 µs N/A
🆕 encode_system.local_query_v4_lz4_compression N/A 14.5 µs N/A
🆕 encode_system.local_query_v4_no_compression N/A 14.5 µs N/A
... ... ... ... ...


:information_source: _Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks._

justinweng-instaclustr commented 2 weeks ago

I pasted the moved code into a diff tool and can confirm that the code is unchanged, except for a few error message typo fixes. Nice!

Thanks for checking! JOOC, what diff tool did you use?

rukai commented 2 weeks ago

Thanks for checking! JOOC, what diff tool did you use?

Not sure 🤣 I googled "web diff tool" and picked the first result.

rukai commented 2 weeks ago

From my history it was: https://www.diffchecker.com/