shotover / shotover-proxy

L7 data-layer proxy
https://docs.shotover.io
Apache License 2.0
83 stars 16 forks source link

KafkaSinkCluster: store first_contact_points as KafkaAddress #1706

Closed rukai closed 1 month ago

rukai commented 1 month ago

This is reduces the need for reallocating and parsing address strings by moving the conversion from string into KafkaAddress into the TransformBuilder creation stage instead of the Transform creation stage.

It is also a prereq to https://github.com/shotover/shotover-proxy/pull/1703

codspeed-hq[bot] commented 1 month ago

CodSpeed Performance Report

Merging #1706 will not alter performance

Comparing rukai:kafka_sink_cluster_contact_points_as_address (c498279) with main (4c146b8)

Summary

✅ 39 untouched benchmarks