shotover / shotover-proxy

L7 data-layer proxy
https://docs.shotover.io
Apache License 2.0
83 stars 16 forks source link

Move to upstream sasl crate + remove unneeded tokio features #1708

Closed rukai closed 1 month ago

rukai commented 1 month ago

To work around missing features in the sasl crate while implementing the scram_over_mtls functionality, I published a temporary fork of the sasl crate for shotover to use while the functionality was being upstreamed. I used the git commit hash as the name of the crate instead of inventing a reasonable to avoid polluting the crates.io namespace with a more useful name https://crates.io/crates/a8da96aa9ee5ce956b7069f92a4ca762efc75133

Since then the upstream sasl crate has a released a new version: 0.5.2 This PR swaps to this new version, there is a small breaking change since the upstreamed version ended up deviating from the initial implementation used in our fork.

In addition, this PR also removes unneeded features enabled in tokio for the shotover crate. This will improve compile times for custom transforms projects and for compiling a final binary without compiling tests.

But this wont improve our compile times during development since we use all tokio features as part of our integration tests and we usually compile tests along with shotover.

codspeed-hq[bot] commented 1 month ago

CodSpeed Performance Report

Merging #1708 will not alter performance

Comparing rukai:update_deps (8260cb5) with main (8adfbf8)

Summary

✅ 39 untouched benchmarks