shotover / shotover-proxy

L7 data-layer proxy
https://docs.shotover.io
Apache License 2.0
83 stars 16 forks source link

Fix KafkaNode state field type #1714

Closed rukai closed 1 month ago

rukai commented 1 month ago

I used the wrong type for this field in https://github.com/shotover/shotover-proxy/pull/1703 and didnt realize until I went to use it. Calling clone on a box will clone the contents of the box as well which is not what we want. What we want is an Arc, which will not clone its contents and instead share the contents between all its clones via reference counting.

codspeed-hq[bot] commented 1 month ago

CodSpeed Performance Report

Merging #1714 will not alter performance

Comparing rukai:fix_atomic_node_state (efb4e2e) with main (93373b2)

Summary

✅ 39 untouched benchmarks