shotover / shotover-proxy

L7 data-layer proxy
https://docs.shotover.io
Apache License 2.0
83 stars 16 forks source link

use const address for wrapper flush #1723

Closed rukai closed 3 weeks ago

rukai commented 1 month ago

avoids the possibility of runtime panic due to unwrap, which allows the optimizer to go harder. Super minor performance improvement I doubt it will show up in any benchmarks, but it did reduce the size of the compiled binary by 2KB.

It also changes the address to 0.0.0.0:0 which is more clearly a dummy address.

codspeed-hq[bot] commented 1 month ago

CodSpeed Performance Report

Merging #1723 will not alter performance

Comparing rukai:use_const_address_for_flush (293aa0a) with main (8c69a10)

Summary

✅ 39 untouched benchmarks