search

shotover / shotover-proxy

L7 data-layer proxy
https://docs.shotover.io
Apache License 2.0
83 stars 16 forks source link

Fix CI by installing samply with --locked #1726

Closed rukai closed 3 weeks ago

rukai commented 3 weeks ago

This PR fixes the currently broken CI. e.g. https://github.com/shotover/shotover-proxy/pull/1723 -> https://github.com/shotover/shotover-proxy/actions/runs/10444413933/job/28918919779?pr=1723

Samply is an external tool used for profiling, our benchmarks automatically install the tool if its not already installed. We started hitting compilation issues when building/installing samply due to a semver violation by one of it dependencies. The addition of --locked fixes the compilation error by forcing it to use the versions specified in its Cargo.lock file. I confirmed this fixes the issue in this instance and should prevent future issues of this kind. I also updated the installed commit to the latest commit of samply to 75a8971b4291db8091a346431a1727ffcec4f038, in order to pull in any samply fixes since the previously pinned commit. May as well do this while touching this code.

codspeed-hq[bot] commented 3 weeks ago

CodSpeed Performance Report

Merging #1726 will not alter performance

Comparing rukai:fix_ci (53d530d) with main (c909d86)

Summary

✅ 39 untouched benchmarks