search

shotover / shotover-proxy

L7 data-layer proxy
https://docs.shotover.io
Apache License 2.0
83 stars 16 forks source link

KafkaSinkCluster handle_connection_error also set Up on success #1737

Closed rukai closed 2 weeks ago

rukai commented 2 weeks ago

This should probably have been done in https://github.com/shotover/shotover-proxy/pull/1715 While we already set the node state to down, we currently have no logic for setting it back to up. If a connection can be made to the node then we should consider it back up. Since this is the opposite logic of "connection fail" -> "set node as down" it makes sense to handle these in the same place, which is what this PR does.

codspeed-hq[bot] commented 2 weeks ago

CodSpeed Performance Report

Merging #1737 will not alter performance

Comparing rukai:set_node_state_up (c014976) with main (e275b2d)

Summary

✅ 39 untouched benchmarks