shotover / shotover-proxy

L7 data-layer proxy
https://docs.shotover.io
Apache License 2.0
87 stars 18 forks source link

KafkaSinkCluster: Add kafka 3.9 integration test #1821

Closed rukai closed 1 week ago

rukai commented 1 week ago

While we do not need to support kafka 3.9 yet, adding an integration test for it is very useful since when investigating how a message type is used in kafka 3.6, being able to check if its used in 3.9 helps rule out if it is actually in 3.6 or not.

To get the integration tests passing with kafka 3.9 I had to handle 2 new message types, this was done by rewriting ApiVersions responses to say that we dont support these message types at all. Refer to the comments in the code for the reasoning.

In the future we could extend the ApiVersions rewriting logic to ensure that future changes to kafka message types dont break shotover, but that is out of scope of this PR.

codspeed-hq[bot] commented 1 week ago

CodSpeed Performance Report

Merging #1821 will not alter performance

Comparing rukai:kafka_3.9 (19ff474) with main (8045ecd)

Summary

✅ 38 untouched benchmarks