Add ffmpeg option and fix small bug with notification framework.

shotr-io / shotr-3

A simple screenshot application for the masses 📷

Apache License 2.0

8 stars 0 forks source link

Add ffmpeg option and fix small bug with notification framework. #104

Closed zacbre closed 3 years ago

zacbre commented 3 years ago

New UI changes:

zacbre commented 3 years ago

fixes #67

github-actions[bot] commented 3 years ago

The artifact is located here: https://github.com/shotr-io/shotr-3/actions/runs/959199464#artifacts

zacbre commented 3 years ago

@Tursko can you test this tomorrow?

Tursko commented 3 years ago

Yes. Can you elaborate more on the notification bug?

zacbre commented 3 years ago

Yes. Can you elaborate more on the notification bug?

https://github.com/shotr-io/shotr-3/pull/104/files#diff-2567da71b828d28c58955923768cc02102bd0b517f87797ab840a52fa5baf302R30

Specifically this part, the notifications would throw an exception if an event wasn't passed...typically happens when running as admin or something else weird happens with windows.