shoulders / qwcrm

QWcrm – Free and Open Source CRM Software.
https://quantumwarp.com/
GNU General Public License v3.0
36 stars 12 forks source link

upgrade error handling #948

Open shoulders opened 6 years ago

shoulders commented 6 years ago

currently when a SQL statement fails I get my custom error page shoing me what function location etc.. But if I enable

require(VENDOR_DIR.'adodb/adodb-php/adodb-exceptions.inc.php');

in adodb.php all adodb/mysql errors are handled by Whoops. This is not a bad thing but is not as quick to diagnose.

These might be useful for later development

force_error_page when used causes headers to be sent and can cause header already sent. i.e. when i disable $VAR['page_no'] global variable for an example

perhaps the error handling might be better changes to SQL error handling because i think all errors that are handled via this method are SQL

Definately do not delete my custom error handling subsystem as it is very useful for finding errors.

shoulders commented 6 years ago

these are all related

ref #915 ref #943 ref #795

shoulders commented 6 years ago

whoops only handles exceptions but my SQL errors are still passed tot he error page.