search

shounakmulay / Telephony

Flutter plugin for telephony features like query device sms directory, listen for incoming messages, retrieve various network parameters, etc.
https://telephony.shounakmulay.dev
MIT License
138 stars 126 forks source link

Fix #79 / #118 : Ignore permission results if we did not initiate the request. #119

Closed Jellepepe closed 2 years ago

Jellepepe commented 2 years ago

Fixes #79 Fixes #118

shounakmulay commented 2 years ago

@Jellepepe Looks like CI is failing.

Jellepepe commented 2 years ago

@Jellepepe Looks like CI is failing.

Flutter analyse is failing in telephony_test.mocks.dart

info • The method doesn't override an inherited method • test/telephony_test.mocks.dart:54:8 • override_on_non_overriding_member
   info • The method doesn't override an inherited method • test/telephony_test.mocks.dart:59:8 • override_on_non_overriding_member

As you can see from my singular commit this is completely separate from my fix (so develop is likely already failing this in its current state).

It seems to be an autogenerated file from the mockito plugin, perhaps it needs to be regenerated?

github-actions[bot] commented 2 years ago

PR marked stale due to no activity.