search

shoutem / ui

Customizable set of components for React Native applications
Other
4.88k stars 456 forks source link

CardStack renders NavigationBar at bottom in latest master #295

Open Swizec opened 6 years ago

Swizec commented 6 years ago

When I use @shoutem/ui from Github, the NavigationBar renders at the bottom of the screen. I'm expecting it to render at the top.

If I switch to tag 0.19.0, then it renders correctly.

Switching @shoutem/ui versions is the only change. My app code is the same.

ShaunSpringer commented 6 years ago

Has this been resolved? Seeing it in 0.22.4

ShaunSpringer commented 6 years ago

Did some digging in the code

https://github.com/shoutem/ui/blame/30746cc41775f3c9c72c8f38a0cc4ba0fe9c3efd/navigation/CardStack.js#L166

At first glance it looks like inlineNavigationBar has to be set explicitly to false in order for the navbar to appear on top.

I assume the order of the elements in that code snippet causes the incorrect ordering of the navbar and rendered scene