search

shoutit / shoutit-web

1 stars 0 forks source link

More languages: es, zh #529

Closed gpbl closed 8 years ago

gpbl commented 8 years ago

@mochawich I see there are two languages finished, while I can test how spanish work, I'm not an expert with chinese. Is the locale code zh correct? Does the localization work as expected? To test it, i'm merging this into develop so the Chinese translator can test on stage:

http://stage.www.shoutit.com?hl=zh

gpbl commented 8 years ago

@mochawich another super-boring task i've to do each time I add a language is to have a localized list of countries: https://github.com/shoutit/shoutit-web/tree/develop/assets/countries How could be a better approach to get the country names? Do we have an API endpoint for that?

nourspace commented 8 years ago

@gpbl thanks, but I', not sure if the languages are applied yet, have we exported the translations?

unfortunately there isn't an endpoint for that. No more languages are going to be added atm beside the total 9 that are on POEditor.

gpbl commented 8 years ago

No, Chinese and Spanish translations are not exported yet, nor languages are available from the footer. This PR is just for testing and to avoid issues if i'm going to add new strings. If we export them now, we can just add the links to the footer and deploy them live (I need to find the countries tough). BTW I have no idea how to push translations to POEditor :)

nourspace commented 8 years ago

we won't add the languages directly below the current ones there should be better design to display ever more languages. I'm not sure if you see the exporting to Github option as it is related to my account settings. I just pushed the translations.