shoutit / shoutit-web

1 stars 0 forks source link

GoogleSignIn double auth request #551

Closed gor181 closed 8 years ago

gor181 commented 8 years ago
gor181 commented 8 years ago

hey @gpbl ,

Please check the changes once you can.

Google is calling our callback for each of events they support PROMPT and AUTO.

PROMPT is always fired once the user has logged in, while AUTO is fired right after PROMPT if user has history of logging in via PROMPT.

You can notice that if you go incognito mode and try to login you will see only 1 fetchr request. Then logout and try again, you will see 2.

gpbl commented 8 years ago

Ah! good catch! I wonder if this change will fix even the issue @mochawich was reporting time ago: if I remember correctly, he had two different accounts and something didn't work correctly.

LGTM, please merge 👍

nourspace commented 8 years ago

:+1: