search

shouya / rss-funnel

Self-hosted RSS multi-tool
https://rss-funnel-demo.fly.dev
GNU General Public License v3.0
108 stars 4 forks source link

Image Proxy Not Working for Certain Comic Feeds #125

Closed tillcash closed 2 months ago

tillcash commented 2 months ago

I tried using the image proxy with a basic configuration on the following feeds. For some feeds, the comic images are not loading, and most of them are not being proxied.

Please feel free to close this issue if this is the intended behavior.

shouya commented 2 months ago

Thanks for pointing out. This is exactly the type of feedback I'm looking for!

I guess it may be because the comic feeds use <img>'s srcset attribute to specify the image source. Whereas in the image proxy filter I only rewrite the src attribute. This feature indeed needs supporting and I will implement that.

shouya commented 2 months ago

@tillcash I have added rewrite for srcset attribute for image_proxy filter. You can test it out quickly by running the latest build and visit: http://127.0.0.1:4080/otf?source=https://www.stickycomics.com/feed/&image_proxy. Could you please help confirm if the fix is working as expected?

tillcash commented 2 months ago

Sure, could you provide the link to the latest build?

shouya commented 2 months ago

Oops, I didn't realize the CI is still running: https://github.com/shouya/rss-funnel/actions/runs/9934137988

You should see the image version here https://github.com/shouya/rss-funnel/pkgs/container/rss-funnel after it's been built.

tillcash commented 2 months ago

I'm afraid the issue still exists for the feed https://poorlydrawnlines.com/feed/. When I right-click and select "open image," it goes to the remote URL instead of the proxy.

My apologies, it's working fine now.