search

showdownjs / ng-showdown

Angular integration for Showdown
BSD 3-Clause "New" or "Revised" License
105 stars 33 forks source link

Angular Support #1

Closed SyntaxRules closed 9 years ago

SyntaxRules commented 9 years ago

I noticed the 1.0.0-beta branch removes the angular support for showdown in the core module. I'm in agreeance with splitting out this into its own repo.

I can build this functionality out. Here's my plan:

  1. Rename this repo (or create a new one) called ngShowdown
  2. Pull in the functionality that was in pre 1.0.0
  3. Add readme details
  4. Add an example
  5. Publish to bower as 'ngShowdown'

@tivie What do you think of the name? (do you care?) Does this sound like a good plan?

tivie commented 9 years ago

Hey @SyntaxRules. I agree with your assessment, so feel free to go ahead. =) I think the name makes sense and I've already renamed the repo per your suggestion.

I would only add the following topics in your plan, before publishing to bower:

@pdeschen what do you think?

pdeschen commented 9 years ago

All in. Unit test would be a must.

As for the name ng-showdown of ngShowdown?

SyntaxRules commented 9 years ago

Just a quick update. I've been using ng-showdown in an application. It works well. I've gotten the test framework running, just have to write the tests. I still need some documentation, but that will be easy after I get the tests done.

tivie commented 9 years ago

@SyntaxRules Great news.

SyntaxRules commented 9 years ago

Done, also published to npm

tivie commented 9 years ago

Tests are failing on travis and also on my localhost.

tivie commented 9 years ago

https://travis-ci.org/showdownjs/ng-showdown