search

showdownjs / ng-showdown

Angular integration for Showdown
BSD 3-Clause "New" or "Revised" License
105 stars 33 forks source link

Tests are failing in Travis CI #12

Closed tivie closed 9 years ago

tivie commented 9 years ago

https://travis-ci.org/showdownjs/ng-showdown

tivie commented 9 years ago

Also, add me to npm repo =P

npm owner add tivie ng-showdown
SyntaxRules commented 9 years ago

@tivie Added.

The travis CI is working for node v0.10 and node v0.12. But it isn't working with node 0.8. I'm not super thrilled about debugging node version 0.8. Is it important that we check node v0.8?

tivie commented 9 years ago

humm... I'm really not sure why it fails on 0.8. The error is:

  ReferenceError: Can't find variable: angular
  at /home/travis/build/showdownjs/ng-showdown/src/ng-showdown.js:9

Regardless, since this is a client-side exclusive library, I don't really think it is necessary to test against all versions of node. In fact, node is only used for running tests so...

SyntaxRules commented 9 years ago

Bower doesn't officially support node 0.8. So running bower via the travis ci wont work.

I removed it, an added node 0.12