search

showdownjs / ng-showdown

Angular integration for Showdown
BSD 3-Clause "New" or "Revised" License
105 stars 33 forks source link

Directive re-write #20

Closed SyntaxRules closed 9 years ago

SyntaxRules commented 9 years ago

Rewrite to avoid doing things the jQuery way. use the built in angular html-binding instead. This solves problems for users that were using jQuery instead of jqlite.

tivie commented 9 years ago

Doesn't this break backwards compatibility?

SyntaxRules commented 9 years ago

I thought about this, this only thing I can think of that breaks backward compatibility is how people apply their styles.

If a user was using the child selector (i.e. ul > li) they will want to change over to using the descendant selector ( i.e. ul li). I didn't really see this as a huge deal.

Is there something that you're seeing that I missed?