search

showdownjs / ng-showdown

Angular integration for Showdown
BSD 3-Clause "New" or "Revised" License
105 stars 33 forks source link

Handle universal module format a little better #22

Closed avishnyak closed 8 years ago

avishnyak commented 8 years ago

The previous version errors out on the client side if another library provides a bad implementation of a "require" function. This pattern is more resilient both in Node and the client browser.

tivie commented 8 years ago

Thanks. The changes seem sensible. However, the code was completely reformatted (two times it seems) which will make very hard to backtrace any bugs. (you can take a look at our code style here)

Can you remake the PR, touching only the lines you changed?

avishnyak commented 8 years ago

Yep, you got it.