search

showdownjs / ng-showdown

Angular integration for Showdown
BSD 3-Clause "New" or "Revised" License
105 stars 33 forks source link

Convert NodeJS load logic to UMD module format. #24

Closed avishnyak closed 8 years ago

avishnyak commented 8 years ago

This commit fixes an issues where the environment has a require function but is not a CommonJS implementation of require.

The first commit in this PR contains the actual logic changes. The second commit brings the PR in line with style requirements and jshint.

tivie commented 8 years ago

@avishnyak Thank you very much for your contribution.

@SyntaxRules Can you have a look into this? Thanks!

SyntaxRules commented 8 years ago

Looks good thanks!

Following semver, i think this requires a minor bump. (No breaking changes, yet no bug fixes either.) If everyone agrees, I'll release this as 1.1.0.

tivie commented 8 years ago

sure, go ahead

avishnyak commented 8 years ago

Do you have any estimate on when you would be able to do the release and get it out on npm?