Replace element. - Githubissues

showdownjs / ng-showdown

Angular integration for Showdown

BSD 3-Clause "New" or "Revised" License

105 stars 33 forks source link

Replace element. #32

Closed GirlBossRush closed 5 years ago

GirlBossRush commented 7 years ago

This PR changes the directive to replace the element it's set on. This fixes issues surrounding CSS selectors targeting the immediate child elements.

SyntaxRules commented 7 years ago

It looks like the Travis CI checks need to be updated to the latest node.js for them to work. @tivie What version on node.js/npm are we supporting for release?

tivie commented 7 years ago

@SyntaxRules Showdown llibrary supports from 0.8 through 7.0. Although we can prolly drop support for node <=0.12 for ng-showdown

SyntaxRules commented 5 years ago

@TeffenEllis can you rebase off master to get the travis CI build to work?

GirlBossRush commented 5 years ago

@SyntaxRules I no longer have commit access to that repo but I can make a new PR shortly.