showdownjs / ng-showdown

Angular integration for Showdown
BSD 3-Clause "New" or "Revised" License
105 stars 33 forks source link

Some options not setting correctly #35

Open JHaller27 opened 5 years ago

JHaller27 commented 5 years ago

I have some options set with $showdownProvider.setOption('<property>', true);. Some of them work, some act as though the option is not being set. (Have not tested extensively, so these are only the options I'm using).

Broken

Option: setOption('underline', true);

Markdown

__text__

Expected Underlined "text" (does not display in GitHub)

Actual "text"


Option: setOption('simpleLineBreaks', true);

Markdown

text
text

Expected "text text"

Actual "text text"

Working

(For sanity check purposes)

Option: setOption('tables', true);

Markdown

| Header1 | Header2 |
|:-------:|:-------:|
| itemA1  | itemA2  |
| itemB1  | itemB2  |

Result

Header1 Header2
itemA1 itemA2
itemB1 itemB2

Option: setOption('headerLevelStart', 2);

Markdown

# I'm a heading

Result (html)

<h2>I'm a heading</h2>
evilaliv3 commented 1 year ago

I think this could be happening when sanitize is enabled.

Do you confirm that you are using it @JHaller27 ?