showdownjs / showdown

A bidirectional Markdown to HTML to Markdown converter written in Javascript
http://www.showdownjs.com/
MIT License
14.19k stars 1.56k forks source link

Strip more international punctuation characters from header ids in `ghCompatibleHeaderId` mode #949

Closed tunetheweb closed 6 months ago

tunetheweb commented 2 years ago

GitHub currently strips the following extended punctuation characters when creating headers in markdown files, but Showdown does not.

Evidence in this gist: https://gist.github.com/tunetheweb/ecbfed99663425a668748770568bdafb#some-header-with--chars

Seems an easy enough fix to add these so will submit a PR.

tivie commented 1 year ago

Hey.

Do you mean GitHub strips these characters from ids?

tunetheweb commented 1 year ago

Correct. If you look at that gist example (markdown gists automatically creates ids) you see it:

image
tivie commented 1 year ago

Thank you. Will be merging the PR.