showdownjs / showdown

A bidirectional Markdown to HTML to Markdown converter written in Javascript
http://www.showdownjs.com/
MIT License
14.1k stars 1.57k forks source link

fix: properly handle a false value for the parseImgDimensions option #985

Open paviad opened 1 year ago

paviad commented 1 year ago

Contains two fixes:

  1. Change the default value of the parseImgDimensions option to true (also in documentation)
  2. Properly reject image dimensions when the option is set to false

Closes #984

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit 456a6f71 and detected 0 issues on this pull request.

View more on Code Climate.

paviad commented 1 year ago

Resolved all issues, new behavior will not reject dimensions, but will simply ignore them.