showlab / X-Adapter

[CVPR 2024] X-Adapter: Adding Universal Compatibility of Plugins for Upgraded Diffusion Model
https://showlab.github.io/X-Adapter/
Apache License 2.0
742 stars 44 forks source link

ComfyUI Implementation #19

Open inferno46n2 opened 9 months ago

inferno46n2 commented 9 months ago

Any consideration for actually implementing this tool into one of the platforms that people are using?

Disheartening to see researchers spend months of time building something like this, then post it only for it to be forgotten about because it's too complicated to implement by a bunch of amateur coders like ourselves or it's so low on the priority list for the devs that could actually implement it that they never do.

Your team has built an incredible tool here and I fear in this fast moving space it's going to be a complete was of time unless you are open to collaborating with the community on what we actually want to use it for <3

Semolce9 commented 8 months ago

Thank you for your advice. You can found ComfyUI implementation here. I will spend some time to implement our method into Gradio and ComfgUI in the next few weeks. Please stay tuned!

inferno46n2 commented 8 months ago

Thank you for your advice. You can found ComfyUI implementation here. I will spend some time to implement our method into Gradio and ComfgUI in the next few weeks. Please stay tuned!

Thank you for the reply! I know Kijai well - we talk daily. His implementation is purely a wrapper and preliminary tests are the reason I even made this post.

It's not a “proper” implementation.

TomLucidor commented 1 month ago

@inferno46n2 what would be the requirements for this to work then? Is the adaptor not properly trained or something? P.S. Cross-wiring to A1111 and other tools under StabilityMatrix https://github.com/showlab/X-Adapter/issues/14